-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPA-1384]: fix(chain): override apollo ID matching for chain #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graham-chainlink
force-pushed
the
ggoh/DPA-1384/apollo-cache-fix
branch
from
December 6, 2024 14:01
8a98d3f
to
4e47959
Compare
graham-chainlink
changed the title
fix(chain): override apollo ID matching for chain
[DPA-1384]: fix(chain): override apollo ID matching for chain
Dec 6, 2024
krehermann
reviewed
Dec 6, 2024
If the chains query returns different chain with same id eg ``` [ { "id": "1", "enabled": true, "network": "aptos", "__typename": "Chain" }, { "id": "1", "enabled": true, "network": "evm", "__typename": "Chain" } ] ``` The default apollo client behaviour is to assume ID is always unique, but it is not the case here so things start to become confused like in the screen shot where both “1” show up for APTOS even though the UI correctly filters it. The fix is to tell apollo client how to handle the uniqueness of the chain object. JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1384
graham-chainlink
force-pushed
the
ggoh/DPA-1384/apollo-cache-fix
branch
from
December 9, 2024 01:29
4e47959
to
8486276
Compare
Quality Gate failedFailed conditions |
ChrisAmora
approved these changes
Dec 9, 2024
graham-chainlink
added a commit
to smartcontractkit/chainlink
that referenced
this pull request
Dec 10, 2024
There was an issue raised [here](https://chainlink-core.slack.com/archives/C06NF17JK9N/p1733437678773739?thread_ts=1733412322.287769&cid=C06NF17JK9N) impacting the chain config dialog of the operator ui, because the chain id is no longer unique now that we work with multichain, we need to handle it better by considering the network and chain id together instead of just chainid. Context: smartcontractkit/operator-ui#97 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1384
github-merge-queue bot
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Dec 10, 2024
There was an issue raised [here](https://chainlink-core.slack.com/archives/C06NF17JK9N/p1733437678773739?thread_ts=1733412322.287769&cid=C06NF17JK9N) impacting the chain config dialog of the operator ui, because the chain id is no longer unique now that we work with multichain, we need to handle it better by considering the network and chain id together instead of just chainid. Context: smartcontractkit/operator-ui#97 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1384
archseer
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Dec 10, 2024
There was an issue raised [here](https://chainlink-core.slack.com/archives/C06NF17JK9N/p1733437678773739?thread_ts=1733412322.287769&cid=C06NF17JK9N) impacting the chain config dialog of the operator ui, because the chain id is no longer unique now that we work with multichain, we need to handle it better by considering the network and chain id together instead of just chainid. Context: smartcontractkit/operator-ui#97 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1384
archseer
pushed a commit
to smartcontractkit/chainlink
that referenced
this pull request
Dec 11, 2024
There was an issue raised [here](https://chainlink-core.slack.com/archives/C06NF17JK9N/p1733437678773739?thread_ts=1733412322.287769&cid=C06NF17JK9N) impacting the chain config dialog of the operator ui, because the chain id is no longer unique now that we work with multichain, we need to handle it better by considering the network and chain id together instead of just chainid. Context: smartcontractkit/operator-ui#97 JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the chains query returns different chain with same id eg
The default apollo client behaviour is to assume ID is always unique, but it is not the case here so things start to become confused like in the screen shot where both “1” show up for APTOS even though the UI correctly filters it.
The fix is to tell apollo client how to handle the uniqueness of the chain object.
JIRA: https://smartcontract-it.atlassian.net/browse/DPA-1384